crowmaki/ai-studio
Watch
1
0
Fork
You've already forked ai-studio
 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

Scene cast (#32) #78

Merged
crowmaki merged 3 commits from issue-32-scene-cast into main 2026-10-07 09:58:15 +00:00
Conversation 0 Commits 3 Files changed 24 +1840 -71
crowmaki commented 2026-10-07 09:53:09 +00:00
Owner
Copy link

Closes #32. Part of #24.

Stacked PR. Review and merge in order: #26 → #27 → #28 → #29 → #30 → #31 → #32. Each PR targets the branch of the one before it.

What

  • Migration V7: scene_cast(scene, character, look, wardrobe_item?). Deferred composite FKs ensure the Look and Wardrobe item belong to the Character. Projects imported earlier are backfilled.
  • Speaking Characters are added on their default Look at import.
  • Undoable edits: add a non-speaker, remove (refused for speakers), change Look, set or clear Wardrobe item. Deleting a Look or Wardrobe item in use is refused. Deleting a non-speaking Character removes its cast rows and restores them on undo.
  • Merge hook: the absorbed Character's cast rows move to the survivor. If both are cast in a Scene, the survivor's row wins.
  • UI: cast block per Scene.

Also in this PR (review fixes across the stack)

  • 6045214:
    • Leading script content attaches to the first Scene that isn't omitted, instead of being dropped.
    • A successful import clears the undo history, so undoing a pre-import title edit can no longer overwrite the imported title.
    • Doc comment on put_blob.
  • bf0708e: rustfmt on files left over from earlier tickets.

Tests

tests/scene_cast.rs, plus new tests in tests/script_import.rs for the fixes.

Checks

  • cargo test --workspace --all-features, cargo clippy --workspace --all-targets --all-features -- -D warnings and bun run check pass.
  • The Svelte UI is type-checked only. It has not been run in the app.
Closes #32. Part of #24. > **Stacked PR.** Review and merge in order: #26 → #27 → #28 → #29 → #30 → #31 → #32. Each PR targets the branch of the one before it. ## What - Migration V7: `scene_cast(scene, character, look, wardrobe_item?)`. Deferred composite FKs ensure the Look and Wardrobe item belong to the Character. Projects imported earlier are backfilled. - Speaking Characters are added on their default Look at import. - Undoable edits: add a non-speaker, remove (refused for speakers), change Look, set or clear Wardrobe item. Deleting a Look or Wardrobe item in use is refused. Deleting a non-speaking Character removes its cast rows and restores them on undo. - Merge hook: the absorbed Character's cast rows move to the survivor. If both are cast in a Scene, the survivor's row wins. - UI: cast block per Scene. ## Also in this PR (review fixes across the stack) - `6045214`: - Leading script content attaches to the first Scene that isn't omitted, instead of being dropped. - A successful import clears the undo history, so undoing a pre-import title edit can no longer overwrite the imported title. - Doc comment on `put_blob`. - `bf0708e`: rustfmt on files left over from earlier tickets. ## Tests `tests/scene_cast.rs`, plus new tests in `tests/script_import.rs` for the fixes. ## Checks - `cargo test --workspace --all-features`, `cargo clippy --workspace --all-targets --all-features -- -D warnings` and `bun run check` pass. - The Svelte UI is type-checked only. It has not been run in the app. 
Co-Authored-By: Claude Sonnet <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet <noreply@anthropic.com>
Co-Authored-By: Claude Opus <noreply@anthropic.com>
crowmaki changed target branch from issue-31-merge-entities to main 2026-10-07 09:58:10 +00:00
crowmaki deleted branch issue-32-scene-cast 2026-10-07 09:58:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
question
More information is needed

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
wayfinder:grilling
Needs a decision talked through with a human

  
wayfinder:map
Index of decisions and open questions for a large effort

  
wayfinder:prototype
Needs a rough artifact built to react to

  
wayfinder:research
Needs facts gathered from docs or external sources

  
wayfinder:task
Manual work that must happen before a decision

  
wontfix
Will not be actioned

No labels
bug
duplicate
enhancement
help wanted
invalid
needs-info
needs-triage
question
ready-for-agent
ready-for-human
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crowmaki/ai-studio!78
No description provided.