crowmaki/ai-studio
Watch
1
0
Fork
You've already forked ai-studio
 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

Mark a Shot complex, with the dot everywhere (#158) #168

Merged
crowmaki merged 2 commits from issue-158-complex-shot into main 2026-10-10 21:28:57 +00:00
Conversation 0 Commits 2 Files changed 20 +407 -21
crowmaki commented 2026-10-10 21:26:20 +00:00
Owner
Copy link

Closes #158. Part of #139.

What changed

  • Complex flag on a Shot. Migration V45 adds shot.complex (false by default). set_shot_complex marks or unmarks a Shot as one undoable edit ("Mark shot complex" / "Unmark shot complex"). Setting the flag a Shot already has records no edit. When a complex Shot is split, only the first part keeps the flag, as with Takes. Undoing the split puts it back.

  • Shot read model. ShotView and BoardView (and their DTOs) gain complex and a previz status, none / current / mismatched. The status is always none until Playblasts exist. A new previz module holds PrevizStatus, ready for the later slices of #139.

  • ComplexShotDot. A small dot before the over budget chip in the four Shot listings: the Board timeline, the Scenes view's Setups block, the Animatic's cut tracks and Dailies. A pure helper (complexShot.ts) maps the status to a colour and a tooltip:

    • grey: no Playblast yet;
    • green: the Playblast matches the Shot;
    • amber: it doesn't match the Shot's length or aspect ratio.

    Shots that aren't complex show no dot.

  • Shot panel. A "Complex shot" switch next to the aspect ratio picker.

  • Docs. CONTEXT.md defines Complex shot, Previz and Playblast. ADR-0006's badge list now includes the dot.

Tests

  • tests/previz.rs (new):
    • A Shot starts not complex, with no previz.
    • Marking and unmarking is undoable and redoable.
    • Setting the current flag is no edit.
    • The flag survives reopening the Project.
    • A split keeps the flag on the first part only.
    • The Board timeline reports it.
  • tests/notation.rs: the hand-made rewind to V14 also drops the new column.
  • Frontend: complexShot.test.ts covers all three statuses and the no-dot case. It uses bun:test, as the other src/lib/scenes tests do, not Vitest as the issue says.
  • The full suites pass: cargo test --workspace --features studio-core/test-support, bun test and bun run check.

Manual

I checked this in the running app with a seeded Project: Scene 1 with Shots 1A and 1B, and 1A marked complex by clicking its "Complex shot" switch label.

  • The undo label read "Mark shot complex". Ctrl+Z took the dot away everywhere, and Ctrl+Y brought it back.
  • The dot's tooltip reads "Complex shot: no playblast yet".
  • 1B, which isn't complex, shows no dot in any listing.

The Scenes view's Setups block, with the switch on and the grey dot after "1 line":

Setups block

The Board timeline:

Board timeline

The Animatic's cut tracks:

Animatic

Dailies:

Dailies

Closes #158. Part of #139. ## What changed - **Complex flag on a Shot.** Migration V45 adds `shot.complex` (false by default). `set_shot_complex` marks or unmarks a Shot as one undoable edit ("Mark shot complex" / "Unmark shot complex"). Setting the flag a Shot already has records no edit. When a complex Shot is split, only the first part keeps the flag, as with Takes. Undoing the split puts it back. - **Shot read model.** `ShotView` and `BoardView` (and their DTOs) gain `complex` and a previz status, `none` / `current` / `mismatched`. The status is always `none` until Playblasts exist. A new `previz` module holds `PrevizStatus`, ready for the later slices of #139. - **`ComplexShotDot`.** A small dot before the over budget chip in the four Shot listings: the Board timeline, the Scenes view's Setups block, the Animatic's cut tracks and Dailies. A pure helper (`complexShot.ts`) maps the status to a colour and a tooltip: - grey: no Playblast yet; - green: the Playblast matches the Shot; - amber: it doesn't match the Shot's length or aspect ratio. Shots that aren't complex show no dot. - **Shot panel.** A "Complex shot" switch next to the aspect ratio picker. - **Docs.** `CONTEXT.md` defines Complex shot, Previz and Playblast. ADR-0006's badge list now includes the dot. ## Tests - `tests/previz.rs` (new): - A Shot starts not complex, with no previz. - Marking and unmarking is undoable and redoable. - Setting the current flag is no edit. - The flag survives reopening the Project. - A split keeps the flag on the first part only. - The Board timeline reports it. - `tests/notation.rs`: the hand-made rewind to V14 also drops the new column. - Frontend: `complexShot.test.ts` covers all three statuses and the no-dot case. It uses `bun:test`, as the other `src/lib/scenes` tests do, not Vitest as the issue says. - The full suites pass: `cargo test --workspace --features studio-core/test-support`, `bun test` and `bun run check`. ## Manual I checked this in the running app with a seeded Project: Scene 1 with Shots 1A and 1B, and 1A marked complex by clicking its "Complex shot" switch label. - The undo label read "Mark shot complex". Ctrl+Z took the dot away everywhere, and Ctrl+Y brought it back. - The dot's tooltip reads "Complex shot: no playblast yet". - 1B, which isn't complex, shows no dot in any listing. The Scenes view's Setups block, with the switch on and the grey dot after "1 line": ![Setups block](https://git.crowmaki.me/attachments/fca37ad6-1224-41bd-a1bd-eff522d4134e) The Board timeline: ![Board timeline](https://git.crowmaki.me/attachments/e8ad516a-a9cd-4594-a985-b90cb8f97d0f) The Animatic's cut tracks: ![Animatic](https://git.crowmaki.me/attachments/0c0b718e-1ebf-48f4-a0fb-2b974353ff06) Dailies: ![Dailies](https://git.crowmaki.me/attachments/977d5861-6c01-4c2d-87a1-d161427907ae)
1-setups.png
65 KiB
2-board.png
46 KiB
3-animatic.png
42 KiB
4-dailies.png
33 KiB 
A Shot gains an undoable complex flag (V45) that a split keeps on its
first part, and the Shot and Board reads gain it with a previz status
(always none until Playblasts exist). A ComplexShotDot beside the over
budget badge on the Board timeline, the Setups block, the Animatic's cut
tracks and Dailies shows it, and the Shot panel gets a Complex shot
switch. CONTEXT.md defines Complex shot, Previz and Playblast.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
crowmaki deleted branch issue-158-complex-shot 2026-10-10 21:28:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
question
More information is needed

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
wayfinder:grilling
Needs a decision talked through with a human

  
wayfinder:map
Index of decisions and open questions for a large effort

  
wayfinder:prototype
Needs a rough artifact built to react to

  
wayfinder:research
Needs facts gathered from docs or external sources

  
wayfinder:task
Manual work that must happen before a decision

  
wontfix
Will not be actioned

No labels
bug
duplicate
enhancement
help wanted
invalid
needs-info
needs-triage
question
ready-for-agent
ready-for-human
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crowmaki/ai-studio!168
No description provided.