crowmaki/ai-studio

Watch

Fork 0

Share badge states and type the job class (#107) #132

Merged

crowmaki merged 2 commits from issue-107-badge-jobclass-cleanup into main

2026-10-09 22:58:26 +00:00

crowmaki commented

2026-10-09 22:57:13 +00:00

Owner

Closes #107

Behaviour doesn't change.

Shared badge states

New src/lib/queue/badge.ts has one Badge type, which replaces TakeBadge and JobBadge, and renderBadge, which builds Queued, Held, Finishing, Rendering N% / Rendering… and Failed.
takeBadge and jobBadge both call renderBadge. Badges that only one side has stay where they are: Not ready, Interrupted, Ready, and the post-step failure.
progressPercent is the one place the Rendering percent is worked out, for both takeBadge and jobPercent.

Typed job class

JobDto.class is now JobClassDto ("image" | "draft" | "final" in bindings.ts). From<JobClass> maps enum to enum, so the strings exist only in serde's rename_all.
WaitingGroup.key in waitingGroups is now "run_next" | JobClassDto.

Checks

cargo test --workspace --all-features: pass
bun test src scripts: pass (285)
bun run check: 0 errors

Closes #107 Behaviour doesn't change. ## Shared badge states - New `src/lib/queue/badge.ts` has one `Badge` type, which replaces `TakeBadge` and `JobBadge`, and `renderBadge`, which builds Queued, Held, Finishing, Rendering N% / Rendering… and Failed. - `takeBadge` and `jobBadge` both call `renderBadge`. Badges that only one side has stay where they are: Not ready, Interrupted, Ready, and the post-step failure. - `progressPercent` is the one place the Rendering percent is worked out, for both `takeBadge` and `jobPercent`. ## Typed job class - `JobDto.class` is now `JobClassDto` (`"image" | "draft" | "final"` in `bindings.ts`). `From<JobClass>` maps enum to enum, so the strings exist only in serde's `rename_all`. - `WaitingGroup.key` in `waitingGroups` is now `"run_next" | JobClassDto`. ## Checks - `cargo test --workspace --all-features`: pass - `bun test src scripts`: pass (285) - `bun run check`: 0 errors

crowmaki added 2 commits

2026-10-09 22:57:13 +00:00

Share badge states and type the job class (#107 ) f979274c19

takeBadge and jobBadge build Queued, Held, Finishing, Rendering and
Failed through one renderBadge helper, with one Badge type. JobDto.class
is a JobClassDto enum, so bindings type it as "image" | "draft" | "final"
and waitingGroups keys are typed.

Address review of shared badge states (#107 ) f64803f6a3

takeBadge and jobPercent share one progressPercent.

crowmaki merged commit 90a801959a into main

2026-10-09 22:58:26 +00:00

crowmaki deleted branch issue-107-badge-jobclass-cleanup

2026-10-09 22:58:26 +00:00

crowmaki referenced this pull request from a commit

2026-10-09 22:58:26 +00:00

Merge pull request 'Share badge states and type the job class (#107)' (#132) from issue-107-badge-jobclass-cleanup into main

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

crowmaki/ai-studio!132

No description provided.

Rows
Columns